X Tutup
Skip to content

Cloud Spanner: Check duplicate columns in Mutation#2263

Merged
vkedia merged 2 commits intogoogleapis:masterfrom
skrulcik:check-duplicates
Aug 22, 2017
Merged

Cloud Spanner: Check duplicate columns in Mutation#2263
vkedia merged 2 commits intogoogleapis:masterfrom
skrulcik:check-duplicates

Conversation

@skrulcik
Copy link
Copy Markdown

close #2257

  • Adds checkDuplicateColumns, executed before a mutation is built, to
    ensure each column name is only used once. Note that column names
    are case-insensitive according to the DDL
    docs
    .
  • Tests duplicate columns with the same case and different cases.
  • Removes duplicate column check in asMap because all Mutations are
    now guaranteed not to have duplicate columns. Removes corresponding test code too.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mutation.WriteBuilder.build() does not check state

4 participants

X Tutup