X Tutup
Skip to content

Fix scripts panel state not being saved when toggle button is used#98936

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
Michakrom:toggle-scripts-panel-save-fix
Nov 20, 2025
Merged

Fix scripts panel state not being saved when toggle button is used#98936
Repiteo merged 1 commit intogodotengine:masterfrom
Michakrom:toggle-scripts-panel-save-fix

Conversation

@Michakrom
Copy link

@Michakrom Michakrom commented Nov 7, 2024

Fix for #98860

When using ctrl + \ or right clicking toggle/hide to toggle the script panel the change would be saved, but when pressing the toggle button the change would not be saved.

The goal of this change is to make it so pressing the toggle button will also save the setting.

Bugsquad edit: fixes #98860

@Michakrom Michakrom requested a review from a team as a code owner November 7, 2024 19:52
@AThousandShips AThousandShips changed the title Fix for a scripts panel state not being saved when toggle button is used Fix scripts panel state not being saved when toggle button is used Nov 8, 2024
@AThousandShips AThousandShips added this to the 4.4 milestone Nov 8, 2024
@Repiteo Repiteo modified the milestones: 4.4, 4.5 Feb 24, 2025
Copy link
Contributor

@kitbdev kitbdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue.
The scripts list was renamed files list, so this will have to be rebased.

@Repiteo Repiteo modified the milestones: 4.5, 4.6 Sep 8, 2025
@Repiteo Repiteo force-pushed the toggle-scripts-panel-save-fix branch from ddcaf36 to f14ed7e Compare November 18, 2025 20:31
@Repiteo Repiteo requested review from a team as code owners November 18, 2025 20:31
@Repiteo
Copy link
Contributor

Repiteo commented Nov 18, 2025

Rebased with rename fixes

@Repiteo Repiteo merged commit e9718d4 into godotengine:master Nov 20, 2025
12 of 14 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 20, 2025

Thanks! Congratulations on your first merged contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Script sidepanel toggle is permanent with ctrl + \ but only temporary with the bottom left arrow

4 participants

X Tutup