Fix ColorPickerButton close popup on mouse click#98428
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Nov 20, 2025
Merged
Conversation
pafuent
force-pushed
the
fixing_color_picker_closing_popup_on_mouse_click
branch
from
589b679 to
6290f1b
Compare
Contributor
Author
|
Can I get a review? |
KoBeWi
reviewed
Nov 13, 2024
Member
|
There is another fix for that issue (#93775), but this one is simpler, so it's more preferable. |
pafuent
force-pushed
the
fixing_color_picker_closing_popup_on_mouse_click
branch
from
6290f1b to
b24d56f
Compare
Contributor
Author
|
(updating to the latest changes on master just because I was here 😉 ) |
pafuent
force-pushed
the
fixing_color_picker_closing_popup_on_mouse_click
branch
from
b24d56f to
32caf48
Compare
pafuent
force-pushed
the
fixing_color_picker_closing_popup_on_mouse_click
branch
from
32caf48 to
077a5fc
Compare
pafuent
force-pushed
the
fixing_color_picker_closing_popup_on_mouse_click
branch
from
077a5fc to
612879f
Compare
pafuent
force-pushed
the
fixing_color_picker_closing_popup_on_mouse_click
branch
from
612879f to
6b29011
Compare
pafuent
force-pushed
the
fixing_color_picker_closing_popup_on_mouse_click
branch
from
6b29011 to
b16b488
Compare
pafuent
force-pushed
the
fixing_color_picker_closing_popup_on_mouse_click
branch
from
b16b488 to
9e7765c
Compare
pafuent
force-pushed
the
fixing_color_picker_closing_popup_on_mouse_click
branch
from
9e7765c to
c82ce1f
Compare
pafuent
force-pushed
the
fixing_color_picker_closing_popup_on_mouse_click
branch
from
c82ce1f to
2ef3ebf
Compare
KoBeWi
approved these changes
Nov 18, 2025
Member
KoBeWi
left a comment
KoBeWi
left a comment
There was a problem hiding this comment.
My comment from a year ago is still valid, but I guess the fix for underlying issue is not coming anytime soon 🤷♂️
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #91813
There is a proposal to fix this properly, because it is out of my league and it seems that nobody started to work on it, I decided to propose this fix as a temporary measure until that proposal is implemented.