GDScript: Remove some unnecessary booleans#98061
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 2, 2025
Merged
Conversation
dalexeev
force-pushed
the
gds-remove-unnecessary-bools
branch
from
1611669 to
72b9f99
Compare
Member
|
It might make sense to include the additional parameter removal from #110692 |
Co-authored-by: HolonProduction <holonproduction@gmail.com>
dalexeev
force-pushed
the
gds-remove-unnecessary-bools
branch
from
72b9f99 to
5f0ecf4
Compare
Member
Author
|
@HolonProduction Done. I've included your changes and listed you as a co-author. |
HolonProduction
approved these changes
Oct 2, 2025
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GDScriptDataType::has_typeand replace it withkind = VARIANT. This is cleaner because it allows us to avoid inconsistent states.GDScriptInstance::base_ref_countedfield. If we need this again for some reason, there are theownerandscriptfields.