Add step out to script debugger#97758
Conversation
|
Just realized Shift+F11 conflicted with "Toggle Fullscreen". Since Shift+F11 contrasting step into's F11 is pretty universal across different editors and IDEs, can we move "Toggle Fullscreen" to Ctrl + Shift + F similar to MacOS or Ctrl + F11? We can also use Ctrl+F11 as "step out", breaking the convention a little bit. If someone in the team can make the decision, I'm happy to implement either. |
|
|
TsFreddie
force-pushed
the
debugger-stepout
branch
from
bfdabe2 to
4994f62
Compare
|
i've moved the default keybind for step out to also rebased. |
TsFreddie
force-pushed
the
debugger-stepout
branch
from
4994f62 to
cd058ba
Compare
|
Most likely this PR will be ignored until formal things like CI fails and branch conflicts will be fixed. @TsFreddie could you please resolve the conflicts and fix the code for passing CI? |
TsFreddie
force-pushed
the
debugger-stepout
branch
2 times, most recently
from
a44b28c to
50f937d
Compare
|
@arkology Thanks for the heads up! I wasn't aware of the style check changes since CI passed 3 months ago. And I wasn't running pre-commit for rebases. Should be good now. |
|
Thanks for resolving conflicts! |
|
what did the chat say @arkology ? the PR seems tiny enough to not need too much effort. |
|
@ridilculous if I remember correctly - nothing :( |
|
@akien-mga could you please request a review from specific contributor for this PR? Thank you! |
| out = memnew(Button); | ||
| out->set_theme_type_variation("FlatButton"); | ||
| hbc->add_child(out); | ||
| out->set_tooltip_text(TTR("Step Out")); |
There was a problem hiding this comment.
BTW if this PR will get a review, TTR most likely should be replaced with TTRC.
There was a problem hiding this comment.
The entire ScriptEditorDebugger still uses TTR. If TTRC is preferred in this context it should probably be done separately with another PR.
Singling out this call to be TTRC while every other calls are still using TTR under the same context is probably messy.
If that happened separately I can rebase again. I usually check back here every few months.
There was a problem hiding this comment.
I think it's better that new code uses TTRC even if old code uses TTR still. We can fix the old code later but we don't know when that will happen.
TsFreddie
force-pushed
the
debugger-stepout
branch
from
50f937d to
9c6dbd9
Compare
TsFreddie
force-pushed
the
debugger-stepout
branch
from
9c6dbd9 to
bc05429
Compare
|
Can't believe! @Ivorforce thank you!❤️ |
|
Thank TsFreddie vnen, all i did was forward your request 😄 |
|
Thanks! Congratulations on your first merged contribution! 🎉 |
Implements the DAP stepOut request by bridging to the existing editor debugger's debug_step_out() method (added in PR godotengine#97758). This will enable external DAP clients (Neovim, Zed, etc.) to step out of functions, matching the capability available in the Godot editor since version 4.6. Implementation follows the existing pattern used by req_next() and req_stepIn(), requiring minimal code changes to the DAP parser. Addresses DAP portion of godotengine/godot-proposals#2815
Implements the DAP stepOut request by bridging to the existing editor debugger's debug_step_out() method (added in PR godotengine#97758). This will enable external DAP clients (Neovim, Zed, etc.) to step out of functions, matching the capability available in the Godot editor since version 4.6. Implementation follows the existing pattern used by req_next() and req_stepIn(), requiring minimal code changes to the DAP parser. Addresses DAP portion of godotengine/godot-proposals#2815
Implements the DAP stepOut request by bridging to the existing editor debugger's debug_step_out() method (added in PR godotengine#97758). This will enable external DAP clients (Neovim, Zed, etc.) to step out of functions, matching the capability available in the Godot editor since version 4.6. Implementation follows the existing pattern used by req_next() and req_stepIn(), requiring minimal code changes to the DAP parser. Addresses DAP portion of godotengine/godot-proposals#2815
8 participants
Implementation for proposal godotengine/godot-proposals#2815
The debugger and gdscript vm are already setup to be able to handle step out. This PR adds the appropriate debugger protocol, the corresponding button, icon, and key-bind
(default to Shift+F11).edit, key-bind now defaults to Alt+F11 see #97758 (comment)