accidently closed by renaming branch, reopen now

I was concerned that the positions of each node would change in the resource file each time your scale changes (problematic for teams), but this is not the case. However, the size does change. In case you have the time, could you check why this is happening? Otherwise I think it would be fine to merge without the size fix.

The positions in the resource file will not change by display scale with or without this fix. The editor stores the top-left position to file. But, with a bigger scale, all nodes will be rendered larger, which makes them overlap with each other.

Which makes the same graph look very different on different display scales. Shaders made by creators with a larger scale (may have a hiDPI display) show more sparse than normal on a smaller display scale and vice versa.

This fix makes no change to the stored position but applies scale to the nodes' position on canvas to avoid this case.

I was concerned that the positions of each node would change in the resource file each time your scale changes (problematic for teams), but this is not the case. However, the size does change. In case you have the time, could you check why this is happening? Otherwise I think it would be fine to merge without the size fix.

I have figured out that the node size is affected by multiple elements.
The most important thing may be font size. And it is scaled by EDSCALE(editor_fonts.cpp:153.).

This screenshot shows the window on display scale 150% but I changed editor_fonts.cpp from

	p_theme->set_default_font_size(default_font_size);

to

	p_theme->set_default_font_size(default_font_size / EDSCALE);

Where default_font_size was set to

// editor_fonts.cpp:153
	const int default_font_size = int(EDITOR_GET("interface/editor/main_font_size")) * EDSCALE;

The editor's theme's base scale is set to EDSCALE(editor_theme_manager.cpp:561).

EDSCALE and theme base scale (In an editor, they are the same thing) are used to determine minimal control size and some line width and content margin, they also affect node size.

This is a really good fix for a problem that is recurrent when more that one person is working on the same visual script.
Node positioning is a really important thing for a readable script and this bug makes it impossible to work at different DisplayScales.

I would really appreciate it if someone would retarget this to 4.5 or 4.6. I would very much like to integrate it to my own Godot build, even if it is not quite finished.

This is a really good fix for a problem that is recurrent when more that one person is working on the same visual script. Node positioning is a really important thing for a readable script and this bug makes it impossible to work at different DisplayScales.

I would really appreciate it if someone would retarget this to 4.5 or 4.6. I would very much like to integrate it to my own Godot build, even if it is not quite finished.

Done, you can test it.

We will very soon try to test this out on 4.5.1.
Will that merge fine ? Or is it more of a 4.6 retarget ?

This might be merged for 4.6, it's currently on the 4.x milestone, it will probably be cherry-picked for a 4.5.x version like 4.5.2

Thanks for the quick answer, I did not know there was a 4.5.2.
Ok So we'll cherry pick and hope it's not gonna be too hard :)

Godot's Editor UI still handles DisplayScale in a very messy way. The best approach may be to use density-independent pixels at the GUI framework level.

This fix isn't perfect. As it stands, a major overhaul of the GUI is needed to remove the use of pixels as the unit of measurement for UI components. We also need to remove the EDSCALE macro to support per-monitor Display Scale.

Thanks!

Cherry-picked for 4.5.2.