Expose 3D editor snap settings to EditorPlugin.#96763
Closed
SaracenOne wants to merge 1 commit intogodotengine:masterfrom
Closed
Expose 3D editor snap settings to EditorPlugin.#96763SaracenOne wants to merge 1 commit intogodotengine:masterfrom
SaracenOne wants to merge 1 commit intogodotengine:masterfrom
Conversation
SaracenOne
force-pushed
the
expose_node_3d_snapping
branch
from
b28975e to
d804630
Compare
Member
Author
|
Okay, fixed now |
|
Thanks for this! I got setting the value work as well: |
dsnopek
approved these changes
Sep 10, 2024
Contributor
dsnopek
left a comment
dsnopek
left a comment
There was a problem hiding this comment.
I also don't know if this is the right place to expose this, however, I have personally wanted the 2D version of this information in addons in the past, so I'm in support of adding it in general.
The code itself looks good to me.
Feedback from folks more involved in the editor would be good.
akien-mga
reviewed
Sep 18, 2024
Comment on lines
+590
to
+607
| <method name="get_node_3d_rotate_snap"> | ||
| <return type="float" /> | ||
| <description> | ||
| Returns the amount of degrees the 3D editor's rotational snapping is set to. | ||
| </description> | ||
| </method> | ||
| <method name="get_node_3d_scale_snap"> | ||
| <return type="float" /> | ||
| <description> | ||
| Returns the amount of units the 3D editor's scale snapping is set to. | ||
| </description> | ||
| </method> | ||
| <method name="get_node_3d_translate_snap"> | ||
| <return type="float" /> | ||
| <description> | ||
| Returns the amount of units the 3D editor's translation snapping is set to. | ||
| </description> | ||
| </method> |
Member
There was a problem hiding this comment.
Wouldn't this make more sense to expose in EditorInterface than EditorPlugin?
Member
There was a problem hiding this comment.
Yes, I agree this makes more sense in EditorInterface.
Member
Author
|
Closed in favour of #103608 since it implements the recommended changes and I agree with them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #10704
Adds methods to the EditorPlugin to get the snap settings from the 3D editor. I don't know whether or not this is the most preferred place to expose this API, but I'm pretty confident this needs to be exposed somewhere at least.