Generate thumbnails on imported scenes.#96544
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Nov 27, 2024
Merged
Conversation
SaracenOne
force-pushed
the
import_thumbnails
branch
from
d934af5 to
7da9533
Compare
Contributor
|
In editor_inteface.cpp error in the comment on line 300 |
Member
|
@SaracenOne Do you think this can be done for the 4.4 cycle? |
Calinou
reviewed
Nov 22, 2024
Member
There was a problem hiding this comment.
Tested locally (rebased on top of master f952bfe), it works as expected.
| 1 | 2 | 3 | 4 |
|---|---|---|---|
 |
 |
 |
 |
Note that you must reimport the scene for the preview to be generated (existing projects won't have one automatically created). Also, it can take a few seconds for the icon to appear in the FileSystem dock after reimporting.
For some assets, it results in a gray preview, presumably due to skinning resulting in a different AABB than needed. This happens with player.glb from the 3D Platformer demo:
Also, cube.glb from the Global Illumination demo is too zoomed in:
zdm2.glb from the same demo is fine though:
Member
|
Going to do a rebase and push it. |
fire
force-pushed
the
import_thumbnails
branch
2 times, most recently
from
26297cc to
00e6791
Compare
This comment was marked as outdated.
This comment was marked as outdated.
fire
force-pushed
the
import_thumbnails
branch
4 times, most recently
from
5efd7b6 to
fce7fa3
Compare
Member
|
We discussed how the thumbnail in imported scenes needs features added.
What do you think about greenlighting the pull request as is and revisiting thumbnails in imported scenes feature enhancements later to see if it can be improved? |
fire
force-pushed
the
import_thumbnails
branch
from
cf698a4 to
74611a7
Compare
AThousandShips
approved these changes
Nov 25, 2024
Repiteo
approved these changes
Nov 27, 2024
Contributor
Repiteo
left a comment
Repiteo
left a comment
There was a problem hiding this comment.
Accepting with the expectation that this will be followed up on soon™ with the aforementioned features
Contributor
|
Thanks! |
53 tasks
demolke
added a commit
to demolke/godot
that referenced
this pull request
Nov 29, 2024
EditorNode is a very heavy object that current test harness cannot create, so after godotengine#96544 editor import cannot be tested. Split off from godotengine#98909
6 tasks
tGautot
pushed a commit
to tGautot/godot
that referenced
this pull request
Feb 5, 2025
EditorNode is a very heavy object that current test harness cannot create, so after godotengine#96544 editor import cannot be tested. Split off from godotengine#98909
tGautot
pushed a commit
to tGautot/godot
that referenced
this pull request
Feb 5, 2025
EditorNode is a very heavy object that current test harness cannot create, so after godotengine#96544 editor import cannot be tested. Split off from godotengine#98909
WhalesState
pushed a commit
to WhalesState/blazium
that referenced
this pull request
Mar 16, 2025
EditorNode is a very heavy object that current test harness cannot create, so after godotengine#96544 editor import cannot be tested. Split off from godotengine#98909
WhalesState
pushed a commit
to WhalesState/blazium
that referenced
this pull request
Mar 16, 2025
EditorNode is a very heavy object that current test harness cannot create, so after godotengine#96544 editor import cannot be tested. Split off from godotengine#98909
WhalesState
pushed a commit
to WhalesState/blazium
that referenced
this pull request
Mar 16, 2025
EditorNode is a very heavy object that current test harness cannot create, so after godotengine#96544 editor import cannot be tested. Split off from godotengine#98909
WhalesState
pushed a commit
to WhalesState/blazium
that referenced
this pull request
Mar 20, 2025
EditorNode is a very heavy object that current test harness cannot create, so after godotengine#96544 editor import cannot be tested. Split off from godotengine#98909
WhalesState
pushed a commit
to WhalesState/blazium
that referenced
this pull request
Mar 20, 2025
EditorNode is a very heavy object that current test harness cannot create, so after godotengine#96544 editor import cannot be tested. Split off from godotengine#98909
JackErb
pushed a commit
to JackErb/godot
that referenced
this pull request
Mar 22, 2025
EditorNode is a very heavy object that current test harness cannot create, so after godotengine#96544 editor import cannot be tested. Split off from godotengine#98909
WhalesState
pushed a commit
to WhalesState/blazium
that referenced
this pull request
Mar 24, 2025
EditorNode is a very heavy object that current test harness cannot create, so after godotengine#96544 editor import cannot be tested. Split off from godotengine#98909
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ends a somewhat long-standing discontinuity of the imported scenes (FBX, GLTF, Collada, ect.) not having any thumbnail previews like regular Godot scenes. It does this by providing a hook step where they can be generated and cached upon reimport.
Keeping this in draft for now since it could probably benefit from further refactoring, improving bounds calculations for skinned meshes, and adding displayable gizmos for the cases where no mesh instances could be found (animation or collision-only imports, for example).