X Tutup
Skip to content

[Windows] Simplify ANGLE fallback list and remove ID checks.#95853

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
bruvzg:win_no_id
Oct 3, 2025
Merged

[Windows] Simplify ANGLE fallback list and remove ID checks.#95853
Repiteo merged 1 commit intogodotengine:masterfrom
bruvzg:win_no_id

Conversation

@bruvzg
Copy link
Member

@bruvzg bruvzg commented Aug 20, 2024

Alternative option for #95852, will force ANGLE on more Gen9 / 9.5 devices, but removes all device ID checks and simplify fallback list.

@Repiteo
Copy link
Contributor

Repiteo commented Oct 2, 2025

Needs rebase

Copy link
Contributor

@Repiteo Repiteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I assume this is marked as a draft because it's between this and #95852 for integration. If so, feel free to remove the draft status from this & I'll just close the other PR once this is merged

@Repiteo Repiteo modified the milestones: 4.x, 4.6 Oct 3, 2025
@bruvzg bruvzg marked this pull request as ready for review October 3, 2025 15:42
@bruvzg bruvzg requested review from a team as code owners October 3, 2025 15:42
@bruvzg
Copy link
Member Author

bruvzg commented Oct 3, 2025

It was marked as draft since we were not blocking gen 9.5 devices when it was created (and this simplification can't tell them from gen 8/9). But gen 9.5 was added to the block list as well, so it's irrelevant now.

@Repiteo Repiteo merged commit 554e16f into godotengine:master Oct 3, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 3, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup