Silence warnings about DisplayServer icons on iOS and visionOS#94542
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Nov 19, 2025
Merged
Conversation
Calinou
added
bug
platform:ios
topic:platforms
cherrypick:4.2
akien-mga
reviewed
Jul 19, 2024
Calinou
force-pushed
the
ios-silence-displayserver-set-icon-warnings
branch
2 times, most recently
from
354cfae to
1788d58
Compare
Calinou
added
the
cherrypick:4.3
Repiteo
added
the
cherrypick:4.4
akien-mga
removed
the
cherrypick:4.2
Repiteo
added
the
cherrypick:4.5
Contributor
|
Needs rebase |
Setting window icons is not supported on iOS or visionOS, but there is no concept of window icons on those platforms anyway.
Calinou
force-pushed
the
ios-silence-displayserver-set-icon-warnings
branch
from
1788d58 to
6de36fe
Compare
Calinou
changed the title
Member
Author
|
Rebased to account for the Apple embedded platform, which means this fix now also benefits visionOS. |
Repiteo
approved these changes
Nov 19, 2025
Contributor
|
Thanks! |
akien-mga
removed
cherrypick:4.3
Member
|
Cherry-picked for 4.5.2. |
akien-mga
removed
the
cherrypick:4.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting window icons is not supported on iOS, but there is no concept of window icons on iOS anyway.