X Tutup
Skip to content

Add unit tests for Decal#93463

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
Tycro-Games:test-decal
Nov 24, 2025
Merged

Add unit tests for Decal#93463
Repiteo merged 1 commit intogodotengine:masterfrom
Tycro-Games:test-decal

Conversation

@OneBogdan01
Copy link
Contributor

Part of the issue: #43440

As stated in the description, I called various setter and getters, then checking whether the function get_aabb() returns the expected result.

@OneBogdan01 OneBogdan01 requested a review from a team as a code owner June 22, 2024 11:38
@AThousandShips AThousandShips changed the title Added unit tests for decal. Add unit tests for Decal Jun 22, 2024
@AThousandShips AThousandShips added this to the 4.x milestone Jun 22, 2024
@OneBogdan01
Copy link
Contributor Author

Well, it seems I do not know how to use the clang formatter from Visual Studio. I am sorry.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, please squash the commits together so we can merge this. See PR workflow for instructions 🙂

@OneBogdan01
Copy link
Contributor Author

I think I am doing something very wrong when merging:
image

@AThousandShips
Copy link
Member

You need to follow the instructions in the link above, you especially have to force push, you didn't force push but did a merge commit instead

@OneBogdan01
Copy link
Contributor Author

You need to follow the instructions in the link above, you especially have to force push, you didn't force push but did a merge commit instead

Yes, I missed the part where I should have a local version of master that is up to date.

@Calinou
Copy link
Member

Calinou commented Sep 22, 2025

Looks good, but please amend the commit message to something more human-readable like:

Add unit tests for Decal

Right now, it's Add include of test decal which doesn't make a lot of sense on its own.

@OneBogdan01
Copy link
Contributor Author

@Calinou that should be fixed now.

@Repiteo Repiteo modified the milestones: 4.x, 4.6 Nov 24, 2025
@Repiteo Repiteo merged commit b962544 into godotengine:master Nov 24, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 24, 2025

Thanks! Congratulations on your first merged contribution! 🎉

@OneBogdan01 OneBogdan01 deleted the test-decal branch November 25, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

X Tutup