Conversation
|
Well, it seems I do not know how to use the clang formatter from Visual Studio. I am sorry. |
Calinou
left a comment
There was a problem hiding this comment.
Looks good to me, please squash the commits together so we can merge this. See PR workflow for instructions 🙂
|
You need to follow the instructions in the link above, you especially have to force push, you didn't force push but did a merge commit instead |
02694c8 to
0c94379
Compare
Yes, I missed the part where I should have a local version of master that is up to date. |
d9c6d1d to
f3b73d8
Compare
|
Looks good, but please amend the commit message to something more human-readable like:
Right now, it's |
f3b73d8 to
bc85a84
Compare
|
@Calinou that should be fixed now. |
|
Thanks! Congratulations on your first merged contribution! 🎉 |

Part of the issue: #43440
As stated in the description, I called various setter and getters, then checking whether the function get_aabb() returns the expected result.