Use Viewport's 3D Scaling in the 3D editor's Half Resolution option#93436
Conversation
Calinou
added
the
cherrypick:4.3
Repiteo
added
the
cherrypick:4.4
Calinou
force-pushed
the
3d-editor-half-resolution-use-3d-scaling
branch
from
42c737b to
e34246e
Compare
|
Rebased and tested again, it works as expected. Note that this does not fix #90843, so a dedicated solution is needed for that regardless (and can be merged independently). |
Calinou
force-pushed
the
3d-editor-half-resolution-use-3d-scaling
branch
from
e34246e to
abba75f
Compare
Repiteo
added
the
cherrypick:4.5
|
Tested, works as expected and makes sense |
There was a problem hiding this comment.
I think this supersedes #33940
This doesn't remember the state properly on reload or when changing scene a couple of times. Node3DEditorViewport::get_state() should be updated to use the popup is_item_checked instead of get_stretch_shrink()
All uses of subviewport_container->get_stretch_shrink() in node_3d_editor_plugin.cpp can be removed, this was the only time it was set in the editor.
Otherwise works well, fixes all of the issues.
Calinou
force-pushed
the
3d-editor-half-resolution-use-3d-scaling
branch
from
abba75f to
1236d7b
Compare
|
Rebased and tested again, it works as expected. I've also changed the viewport size in the View Information panel to take the Scaling 3D > Scale project setting into account, as well as the half-resolution toggle. |
Calinou
force-pushed
the
3d-editor-half-resolution-use-3d-scaling
branch
from
1236d7b to
0b66ec4
Compare
This removes the reliance on Viewport shrinking, which fixes various bugs with mouse input handling in 3D gizmos or the GridMap editor. This also makes Half Resolution make use of the current 3D scaling mode defined in the project setting (bilinear, FSR1 or FSR2). When Half Resolution is checked, the Scaling 3D Scale value in the project settings is halved in the editor. To ensure the 3D view remaisn somewhat readable, the final value can't go below the minimum value allowed in the project settings, which is 0.25.
Calinou
force-pushed
the
3d-editor-half-resolution-use-3d-scaling
branch
from
0b66ec4 to
54a6e67
Compare
|
Thanks! |
akien-mga
removed
cherrypick:4.3
|
Cherry-picked for 4.5.2. |
akien-mga
removed
the
cherrypick:4.5
6 participants
which is less invasive, and could be merged for 4.3 as it fixes several bugs.
This removes the reliance on Viewport shrinking, which fixes various bugs with mouse input handling in 3D gizmos or the GridMap editor.
This also makes Half Resolution make use of the current 3D scaling mode defined in the project setting (bilinear, FSR1 or FSR2).
When Half Resolution is checked, the Scaling 3D Scale value in the project settings is halved in the editor. To ensure the 3D view remains somewhat readable, the final value can't go below the minimum value allowed in the project settings, which is 0.25.
Note that Half Resolution will now look different than it does previously, as it no longer uses nearest-neighbor filtering. For nearest-neighbor filtering to be reimplemented as an option, #79731 needs to be merged.
3D scaling is supported in all rendering methods since 4.3, so this should be safe to cherry-pick for 4.3.
closes Half Resolution viewport option breaks Path3D editing #41586
and closes Can't edit CollisionShape3D with Half Resolution #93355.