GDScript: Make check for exposed classes more consistent#91617
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Nov 25, 2025
Merged
GDScript: Make check for exposed classes more consistent#91617Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
Member
HolonProduction
left a comment
HolonProduction
left a comment
There was a problem hiding this comment.
No need to call it twice, or am I missing something?
vnen
force-pushed
the
gdscript-only-check-exposed-classes
branch
from
3c0d354 to
3331f4c
Compare
Member
Author
|
Applied suggestions by @HolonProduction (thanks!) |
HolonProduction
approved these changes
Nov 21, 2025
Member
HolonProduction
left a comment
HolonProduction
left a comment
There was a problem hiding this comment.
The changes make sense to me.
The above comment about the include in the header file still stands as far as I can see.
Some places were already checking if classes from ClassDB were exposed, while others didn't. This makes the check more consistent to avoid disparities which can lead to crashes.
vnen
force-pushed
the
gdscript-only-check-exposed-classes
branch
from
3331f4c to
501c5b0
Compare
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some places were already checking if classes from ClassDB were exposed, while others didn't. This makes the check more consistent to avoid disparities which can lead to crashes.
Fix #91308