Don't redraw invisible CanvasItems#90401
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 24, 2025
Merged
Conversation
KoBeWi
commented
Apr 8, 2024
| } | ||
|
|
||
| RenderingServer::get_singleton()->canvas_item_clear(get_canvas_item()); | ||
| //todo updating = true - only allow drawing here |
Member
Author
There was a problem hiding this comment.
Not sure what this TODO is about. It seems to have been resolved since forever.
KoBeWi
force-pushed
the
I_wonder_how_much_this_breaks
branch
from
4bedb78 to
7feb601
Compare
Member
Author
|
Ok I removed the viewport part. It can be done in a separate PR, if ever. |
Calinou
approved these changes
Aug 22, 2025
clayjohn
reviewed
Aug 23, 2025
KoBeWi
force-pushed
the
I_wonder_how_much_this_breaks
branch
from
7feb601 to
6abfa4b
Compare
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves 2D performance by ignoring redraw callback of invisible CanvasItemts. It's especially relevant for the editor, e.g. active AnimatedSprite will no longer cause redraw if you are in script editor.