Conversation
|
I support this conceptually, but we need to make sure it works nicely on small resolutions with any script name. This bar of controls already introduces issues with content overflow in some languages which translate verbosely, like French. |
|
I checked French editor and there is no problem in 1920, but lower resolutions might have problems. Though not sure how to make it friendly for low resolutions. If I enable trimming, the text is shrunk to 0. I can't think of a way to have a centered, trimmed text with an icon next to it. |
|
What's the point of showing the script's name twice, exactly? |
|
It's not shown when you shrink the left panel (and can still be switched when switching scenes). |
I think the people who do that does so because they don't have enough horizontal space, the situation where this feature might be a problem. 😛 |
As someone who had a collapsed script list and made a plugin to turn it into a dock when working on a smaller laptop, I'd say that having a name visible is a necessity in that case. Although I put it on the bottom bar in my plugin: |
|
There's quite a lot of demand in the community for having script tabs at the top, instead of scene tabs, when in the script editor. This may replace the need for such a change if we were to go this way (even detached, the script editor should still have tabs at the top to switch between scripts IMO). Otherwise, if we don't go this route or keep it configurable, I see the need for making the current script name more prominent. But I have concerns about the usability of the approach here, the top bar is quite busy and the added name doesn't particularly stand out compared to other buttons. And indeed on smaller resolutions / long script names / some locales this could become a problem. Maybe Yuri's approach to put it in the footer would be better. |
|
I'm personally more keen to the bottom approach. |
Couldn't the error just replace the name once it appears? I don't think it's that important to show both at the same time. |
fe699a4 to
2fa3006
Compare
|
I removed the icon and enabled trimming in the label, so it doesn't enforce minimum size: godot.windows.editor.dev.x86_64_8pPXY12wj1.mp4Since moving it to bottom is going to be a hassle, I'd prefer doing that only if the above solution is not sufficient. |
There was a problem hiding this comment.
It makes sense to take advantage of this empty space, and adding the name helps add clarity.
And its already partially implemented so we should to do something about it.
Also I think it is fine at the top, having it at the bottom but only if there are no errors seems like it would be confusing.
2fa3006 to
2d107f7
Compare
2d107f7 to
55fbd73
Compare
55fbd73 to
206d4a0
Compare
|
Thanks! |


Closes godotengine/godot-proposals#8317

Fun fact: the script name and icon on top was always there, and even updated properly, but never displayed after
hide(). The PR simply makes it visible (I also did some tweaks/cleanup).Also removed the name on left and moved the sort icon next to filter.