X Tutup
Skip to content

Allow editing editor settings from project manager#82212

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
KoBeWi:project_manager_got_more_competent
Nov 12, 2025
Merged

Allow editing editor settings from project manager#82212
Repiteo merged 1 commit intogodotengine:masterfrom
KoBeWi:project_manager_got_more_competent

Conversation

@KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Sep 23, 2023

Closes godotengine/godot-proposals#1602

godot.windows.editor.dev.x86_64_oT89EXm1O4.mp4

I had to add a couple random ifs to decouple EditorSettingsDialog and related controls from EditorNode. Also the dialog requires a few singletons. They are initialized when opening it for the first time, so there is a short freeze.

@KoBeWi KoBeWi added this to the 4.x milestone Sep 23, 2023
@KoBeWi KoBeWi force-pushed the project_manager_got_more_competent branch from 53d5b13 to bff69a7 Compare September 23, 2023 21:11
@Calinou
Copy link
Member

Calinou commented Sep 23, 2023

I get a build error (with and without SCU build enabled):

editor/project_manager.cpp: In member function 'void ProjectManager::_show_editor_settings()':
editor/project_manager.cpp:2628:17: error: 'EditorHelp' has not been declared
 2628 |                 EditorHelp::generate_doc();
      |                 ^~~~~~~~~~
scons: *** [editor/project_manager.linuxbsd.editor.x86_64.o] Error 1
scons: building terminated because of errors.
[Time elapsed: 00:00:23.472]

Also, according to the video you posted, the editor settings window is too tall to fit within the project manager's default size. It should be possible to use a smaller default size for it when in the project manager.

@YuriSizov
Copy link
Contributor

I think we wanted to have a simplified version of the dialog in the PM, just some essentials as to not overwhelm users with settings and provide only those which may be wanted before editing a project.

@KoBeWi KoBeWi force-pushed the project_manager_got_more_competent branch from bff69a7 to 463a6d1 Compare September 23, 2023 21:34
@KoBeWi
Copy link
Member Author

KoBeWi commented Sep 23, 2023

We can have simplified version when we add Advanced toggle to Editor Settings.

@YuriSizov
Copy link
Contributor

Well, IIRC the idea was for something really really simplified. Like having language, scale, theme, but not much else. Something that helps to set up the initial experience.

@KoBeWi
Copy link
Member Author

KoBeWi commented Sep 23, 2023

Well there is use-case for other settings too, e.g. godotengine/godot-proposals#1602 (comment)
Not sure what idea do you refer to, as it's not in the linked proposal.

@YuriSizov
Copy link
Contributor

Yes, it's not. I'm just recalling discussions that we had before. Maybe there are some comments in other proposals or issues that refer to them. In any case, just thought I'd mention it.

@aaronfranke
Copy link
Member

aaronfranke commented Oct 10, 2023

@YuriSizov I would rather have every setting be available, using the same code as the editor settings when a project is open. All of these settings are not tied to a project, so they should not be required to be edited from within a project. Also, some settings require a restart of the editor to take effect, like setting the Blender path, so it's better to go PM -> Settings -> Project than PM -> Project -> Settings -> Project (and with the latter, the first time you open the project it may not load correctly because Godot is unable to import the Blender files).

@Calinou
Copy link
Member

Calinou commented Oct 11, 2023

In the long run, we should have dedicated "simple" Project Settings and Editor Settings dialogs (not just a listing of options but with dedicated UI), but until then, exposing the current editor settings dialog is a net upgrade.

@aaronfranke
Copy link
Member

@KoBeWi Can you rebase this? I would still like to have the full editor settings available here, so to me it's a desired feature.

@KoBeWi KoBeWi force-pushed the project_manager_got_more_competent branch from 463a6d1 to 3e68dd8 Compare November 12, 2025 14:03
@KoBeWi KoBeWi requested a review from a team November 12, 2025 14:03
@KoBeWi KoBeWi requested a review from a team as a code owner November 12, 2025 14:03
@KoBeWi KoBeWi force-pushed the project_manager_got_more_competent branch from 3e68dd8 to a1340f0 Compare November 12, 2025 15:34
Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works, and the code looks good to me.

@Repiteo Repiteo modified the milestones: 4.x, 4.6 Nov 12, 2025
Copy link
Contributor

@Repiteo Repiteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition and painless inclusion; let's give it a go!

@Repiteo Repiteo merged commit df3e70b into godotengine:master Nov 12, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 12, 2025

Thanks! Excellent job getting this put together!

@KoBeWi KoBeWi deleted the project_manager_got_more_competent branch November 12, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow editing the editor settings from inside the project manager

5 participants

X Tutup