Add icons to some editor classes#82121
Conversation
MewPurPur
force-pushed
the
more-icons
branch
from
7b60ec6 to
f3dc869
Compare
|
Oops botched it up. EditorCommandPalette is meant to be this:
|
MewPurPur
force-pushed
the
more-icons
branch
from
f3dc869 to
2e6d1f6
Compare
|
Why was this blocked again? I remember some discussion about the use of colored icons vs drab icons but nothing recent. |
|
Looks good to me on the screenshot, but I can't figure out how to display editor-only nodes in the Create New Node dialog so I can preview the icons (including in light mode). |
|
Light mode was taken into account, but if you want to check it out, you should pull up the help dialog with F1. |
MewPurPur
force-pushed
the
more-icons
branch
2 times, most recently
from
175e575 to
6d4380c
Compare
|
Rebased and tweaked the inspector icon into this simpler one: |
|
I don't know what could be causing checks to fail. |
|
You probably need to rebase. There was some CI issue. |
KoBeWi
left a comment
KoBeWi
left a comment
There was a problem hiding this comment.
I like the idea of unique color for editor classes.
Looks good, though these icons are rarely seen outside documentation (and maybe plugins like EditorDebugger).
|
@MewPurPur This needs to be rebased, but otherwise this looks good to me. |
|
Thanks! |
7 participants
A few concerns: What about nodes vs refcounteds and objects? We don't really use color for anything other than nodes and resources as of now, with the only exception being Tween. But maybe editor-only objects I'll still give them a tint if we add icons to any in the future.