Add a border to tooltips when using the Draw Extra Borders editor setting#76267
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 9, 2025
Merged
Conversation
Calinou
force-pushed
the
editor-theme-extra-borders-tooltip
branch
from
0c1a372 to
0c11920
Compare
ryevdokimov
approved these changes
Jan 31, 2024
Contributor
|
It's the RichTextLabel that's part of EditorHelpBit that's causing the double borders. This isn't the correct way to do it, but the double borders can be removed by doing this.
|
Member
|
A better way to remove the double border is adding a new Stylebox for EditorHelpBit, which by default would be the same as RichTextLabel. |
Calinou
force-pushed
the
editor-theme-extra-borders-tooltip
branch
from
0c11920 to
cbb98ac
Compare
Member
Author
Done: Before
After
|
Calinou
force-pushed
the
editor-theme-extra-borders-tooltip
branch
from
cbb98ac to
354e717
Compare
KoBeWi
approved these changes
Oct 20, 2024
Contributor
|
Looks good to go, but could use a rebase |
…ting This distinguishes tooltips from the background when using the Black (OLED) editor theme preset.
Calinou
force-pushed
the
editor-theme-extra-borders-tooltip
branch
from
354e717 to
7fe3a66
Compare
Member
Author
|
Rebased and tested again, it works as expected. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This distinguishes tooltips from the background when using the Black (OLED) editor theme preset.
Preview
Before
After
A side effect is that this causes a second border to appear outside the EditorHelpBit tooltips for documentation:
It's not a dealbreaker, but it looks a bit odd. I'm not sure where the existing border around those is defined – it should probably be removed. I can't find any mentions of a border in the EditorHelpBit or EditorInspector source code.