Decouple EditorInterface from EditorPlugin#76176
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Apr 18, 2023
Merged
Decouple EditorInterface from EditorPlugin#76176akien-mga merged 1 commit intogodotengine:masterfrom
EditorInterface from EditorPlugin#76176akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
YuriSizov
changed the title
EditorInterface from EditorPlugin
KoBeWi
reviewed
Apr 17, 2023
KoBeWi
reviewed
Apr 17, 2023
KoBeWi
reviewed
Apr 17, 2023
- Simplify some includes in the process. - Also exposes EditorInterface.movie_maker_enabled as a property.
YuriSizov
force-pushed
the
editor-extracted-interface-commencing
branch
from
fca5b44 to
49d7041
Compare
Contributor
Author
|
Addressed the comments about checks, for I kept the singleton check for |
KoBeWi
approved these changes
Apr 17, 2023
Member
|
Thanks! |
This was referenced Apr 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a part of #75694 that contains only the refactoring of
EditorInterfaceinto its own files. It also contains changes to includes, the way the singleton is accessed throughout the codebase, and exposesEditorInterface.movie_maker_enabledas a property.In this PR the base class of the
EditorInterfaceis still changed toObject, as there is no real reason for it to be a node. This should not be a problem for anyone using this singleton though.