Fix collide_shape return type#75260
Merged
YuriSizov merged 1 commit intogodotengine:masterfrom Mar 25, 2023
Merged
Conversation
Fix PhysicsDirectSpaceState3D::_collide_shape return type. Also PhysicsDirectSpaceState2D::_collide_shape.
rburing
force-pushed
the
fix_collide_shape_return
branch
from
dc060cf to
61429a5
Compare
YuriSizov
approved these changes
Mar 25, 2023
Contributor
|
Thanks! |
Contributor
|
Cherry-picked for 4.0.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type used to be a plain
Arrayof vectors, so now it is aTypedArrayof vectors.For both 2D and 3D.
PhysicsDirectSpaceStatecollide_shapereturns the wrong type #75207