X Tutup
Skip to content

SCsub: Add python shebang as a hint for syntax highlighting#6850

Merged
akien-mga merged 1 commit intogodotengine:masterfrom
akien-mga:pr-scsub-shebang
Oct 17, 2016
Merged

SCsub: Add python shebang as a hint for syntax highlighting#6850
akien-mga merged 1 commit intogodotengine:masterfrom
akien-mga:pr-scsub-shebang

Conversation

@akien-mga
Copy link
Member

It's a Unix shebang but I know at least from @vnen that it works as a hint for python syntax highlighting in Notepad++ on Windows.

Works fine for syntax highlighting in Kate and nano.

@zaps166
Copy link
Contributor

zaps166 commented Oct 17, 2016

Also #!/usr/bin/env python can be used :)

@akien-mga
Copy link
Member Author

Also #!/usr/bin/env python can be used :)

True, but I've seen it used less often and wasn't sure that all text editors would recognize it properly. But I haven't tested it to confirm :)

@zaps166
Copy link
Contributor

zaps166 commented Oct 17, 2016

Works on Kate and Notepad++ :)

Other not tested :D

Also switch existing shebangs to "better" /usr/bin/env python.
@akien-mga
Copy link
Member Author

Rebased to use the env one ;)

@akien-mga akien-mga merged commit e96c49f into godotengine:master Oct 17, 2016
@akien-mga akien-mga deleted the pr-scsub-shebang branch October 17, 2016 18:13
@vnen vnen mentioned this pull request Oct 17, 2016
@hubbyist
Copy link

hubbyist commented Oct 18, 2016

bin/SCsub, bin/tests/SCsub shebang's are different from other files. Is it intentional?

@akien-mga
Copy link
Member Author

Looks like ripgrep ignores bin/ folders, so I missed those when doing the search and replace :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup