Fix find next (f3) match line behind find bar#117261
Open
Cboyd97 wants to merge 1 commit intogodotengine:masterfrom
Open
Fix find next (f3) match line behind find bar#117261Cboyd97 wants to merge 1 commit intogodotengine:masterfrom
Cboyd97 wants to merge 1 commit intogodotengine:masterfrom
Conversation
…bar: changed line 220 in code_editor.cpp from text_editor->center_viewport_to_caret(0); to base_text_editor->center_viewport_to_caret(); This allows the caret tp be centered in the viewport after all pending layout recalculations in the tree are completed
AThousandShips
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changed line 220 in code_editor.cpp from
text_editor->center_viewport_to_caret(0); to
base_text_editor->center_viewport_to_caret();
This centers the caret in the viewport after layout recalculations have been done. This means that editor will wait until the find bar has appeared fully before it scrolls to find the match, making the match appear above the find line instead of behind it.