Use luminance multiplier for sky background when using mobile renderer with HDR2D#114804
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Jan 10, 2026
Merged
Use luminance multiplier for sky background when using mobile renderer with HDR2D#114804akien-mga merged 1 commit intogodotengine:masterfrom
akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
akien-mga
approved these changes
Jan 10, 2026
Member
|
Thanks! |
rivie13
pushed a commit
to rivie13/Phoenix-Agentic-Engine
that referenced
this pull request
Feb 16, 2026
Use luminance multiplier for sky background when using mobile renderer with HDR2D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #113597
The
sky_luminance_multiplieris fixed at0.5since the radiance map will always use an LDR format. When rendering to the viewport directly, we should useinverse_luminance_multiplierwhich changes between1.0and0.5depending on if HDR2D is enabled or not.The rest of the sky update functions render to LDR textures always, so they need to use the
sky_luminance_multiplier