LSP: Reuse stale parsers in request#114791
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Jan 9, 2026
Merged
Conversation
akien-mga
approved these changes
Jan 9, 2026
Member
|
Unit tests seem to fail. |
HolonProduction
force-pushed
the
lsp/reuse-stale-parsers-in-request
branch
from
43c5807 to
9d90a67
Compare
Member
|
Thanks! |
rivie13
pushed a commit
to rivie13/Phoenix-Agentic-Engine
that referenced
this pull request
Feb 16, 2026
…stale-parsers-in-request LSP: Reuse stale parsers in request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #114729
When a parser is requested for a script which is not opened in the external editor, a new parser for the script gets created and the old parser for the script gets freed. The idea was to always refresh those from disk since we don't know when they change.
However if a pointer to the old parsers was stored and then a parser was requested for the path again, the old parser would be freed even though there still is a pointer to it.
This PR changes the cleanup logic for stale parsers to reuse them as long as we are in the same request. All stale parsers are cleaned up after the the request finished. This prevents those heap-use-after-free issues.