Fix TextEdit Shift+Click selection start position#114772
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Jan 9, 2026
Merged
Fix TextEdit Shift+Click selection start position#114772Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
akien-mga
approved these changes
Jan 9, 2026
bruvzg
approved these changes
Jan 9, 2026
bruvzg
reviewed
Jan 9, 2026
kitbdev
force-pushed
the
fix-te-shift-click
branch
from
d46504d to
9813c83
Compare
Contributor
|
Thanks! |
rivie13
pushed a commit
to rivie13/Phoenix-Agentic-Engine
that referenced
this pull request
Feb 16, 2026
Fix TextEdit Shift+Click selection start position
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shift + Clickto select words is broken #114738There were 2 issues here.
On symbol lookup click in CodeEdit, the mouse released event never makes it to TextEdit, so the logic that changes the selection mode in #111535 never gets hit.
Moving the caret with the arrow keys or directly with the function never updated the word column, which is now needed.
The symbol lookup now falls through to TextEdit.
The word beg/end columns are now set when the selection origin is updated, which includes
select(), so it should always be updated by the time they are used in_update_selection_mode_pointer. This also covers ones from_pre_shift_selectionthat I removed.Added a few tests, and made the tests in this test case always send a mouse release event to be more accurate to expected behavior.