X Tutup
Skip to content

Fix Skeleton3D edit mode usability issues#114752

Merged
akien-mga merged 1 commit intogodotengine:masterfrom
mxtherfxcker:fix/skeleton3d-usability-issues
Jan 10, 2026
Merged

Fix Skeleton3D edit mode usability issues#114752
akien-mga merged 1 commit intogodotengine:masterfrom
mxtherfxcker:fix/skeleton3d-usability-issues

Conversation

@mxtherfxcker
Copy link
Contributor

@mxtherfxcker mxtherfxcker commented Jan 8, 2026

Description

Improves the usability of Skeleton3D edit mode by fixing bone selection and undo/redo functionality.

Problem

Skeleton3D edit mode had several usability issues:

  1. Bones could only be selected in Select mode, requiring constant mode switching
  2. Bone selection hitbox was too small (4px), making it difficult to click on bones
  3. Undo/redo didn't work after transforming bones because original state wasn't captured correctly
  4. Transform tool mode wasn't properly supported

Related Issues

Fixes #114749

@mxtherfxcker mxtherfxcker requested a review from a team January 8, 2026 17:14
AThousandShips
AThousandShips reviewed Jan 8, 2026
View reviewed changes
@mxtherfxcker mxtherfxcker force-pushed the fix/skeleton3d-usability-issues branch from 4aa93e0 to 30ec446 Compare January 8, 2026 17:29
@mxtherfxcker
Copy link
Contributor Author

mxtherfxcker commented Jan 8, 2026

@AThousandShips done.

@fire fire requested a review from a team January 8, 2026 22:23
@AThousandShips AThousandShips added bug topic:animation topic:3d cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release cherrypick:4.6 Considered for cherry-picking into a future 4.6.x release labels Jan 9, 2026
@AThousandShips AThousandShips added this to the 4.7 milestone Jan 9, 2026
@mxtherfxcker
Copy link
Contributor Author

mxtherfxcker commented Jan 9, 2026

@TokageItLab Can you do a review in your free time?

@TokageItLab TokageItLab modified the milestones: 4.7, 4.6 Jan 10, 2026
@TokageItLab TokageItLab added topic:editor and removed cherrypick:4.6 Considered for cherry-picking into a future 4.6.x release labels Jan 10, 2026
TokageItLab
TokageItLab approved these changes Jan 10, 2026
View reviewed changes
Copy link
Member

@TokageItLab TokageItLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#114749 issue seems to be a regression that depends on the implementation of Selection mode. I strongly recommend merging it into 4.6.

@TokageItLab TokageItLab removed the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Jan 10, 2026
@TokageItLab
Copy link
Member

TokageItLab commented Jan 10, 2026 •
edited
Loading

I think merging this PR is fine, but it would be better to see if there's a better way to fix the regression (to ensure this regression does not occur in other editors using Gizmo, and to investigate why it occurred) @ryevdokimov.

TokageItLab
TokageItLab reviewed Jan 10, 2026
View reviewed changes
@mxtherfxcker mxtherfxcker force-pushed the fix/skeleton3d-usability-issues branch from 30ec446 to 8dd1b6b Compare January 10, 2026 08:40
@mxtherfxcker mxtherfxcker force-pushed the fix/skeleton3d-usability-issues branch from 8dd1b6b to 14a7c0f Compare January 10, 2026 08:41
@mxtherfxcker
Copy link
Contributor Author

mxtherfxcker commented Jan 10, 2026

@TokageItLab done.

@mxtherfxcker
Copy link
Contributor Author

mxtherfxcker commented Jan 10, 2026

I requested the review by mistake

@akien-mga akien-mga merged commit 94971e1 into godotengine:master Jan 10, 2026
20 checks passed
@akien-mga
Copy link
Member

akien-mga commented Jan 10, 2026

Thanks!

@mxtherfxcker mxtherfxcker deleted the fix/skeleton3d-usability-issues branch January 10, 2026 14:17
@kawandev2025
Copy link

kawandev2025 commented Jan 15, 2026

Can you fix this error? When I drag any node into the skeleton tree, the engine crashes.

@kawandev2025
Copy link

kawandev2025 commented Jan 15, 2026

If I try to start another animation within the animation in the Animation Player, it crashes, and every time I go back into the engine it keeps crashing.

@akien-mga
Copy link
Member

akien-mga commented Jan 15, 2026

@kawandev2025 Please open a new bug report with details on how to reproduce the issue.

@TokageItLab TokageItLab mentioned this pull request Jan 29, 2026
Closed
@ryevdokimov ryevdokimov mentioned this pull request Jan 29, 2026
Merged
@TokageItLab TokageItLab mentioned this pull request Feb 2, 2026
Merged
rivie13 pushed a commit to rivie13/Phoenix-Agentic-Engine that referenced this pull request Feb 16, 2026
@akien-mga
Merge pull request godotengine#114752 from mxtherfxcker/fix/skeleton3…
c593068 
…d-usability-issues

Fix Skeleton3D edit mode usability issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@TokageItLab TokageItLab TokageItLab approved these changes

Assignees

No one assigned

Labels

bug regression topic:animation topic:editor topic:3d

Projects

None yet

Milestone

4.6

Development

Successfully merging this pull request may close these issues.

Skeleton3D node Edit Mode is almost unusable

5 participants

@mxtherfxcker @TokageItLab @akien-mga @kawandev2025 @AThousandShips
X Tutup