X Tutup
Skip to content

Keep other parts of transform gizmo visible when rotating in local mode#114714

Merged
akien-mga merged 1 commit intogodotengine:masterfrom
Open-Industry-Project:local-transform-gizmo-visible
Jan 10, 2026
Merged

Keep other parts of transform gizmo visible when rotating in local mode#114714
akien-mga merged 1 commit intogodotengine:masterfrom
Open-Industry-Project:local-transform-gizmo-visible

Conversation

@ryevdokimov
Copy link
Contributor

@ryevdokimov ryevdokimov commented Jan 8, 2026

Fixes: #114672

Note that the view axis rotation ring converts to old transform gizmo size so that things look a little more cohesive when rotating.

2026-01-07.14-13-48.mp4

@ryevdokimov ryevdokimov requested a review from a team January 8, 2026 02:03
@ryevdokimov ryevdokimov changed the title Local transform gizmo visible Keep other parts of transform gizmo visible when rotating in local mode Jan 8, 2026
@TokageItLab
Copy link
Member

TokageItLab commented Jan 8, 2026

I think this should be an option in EditorSettings like hide axes during rotation same as #114717. Although I think the default setting to show arrows is fine.

@TokageItLab TokageItLab added this to the 4.6 milestone Jan 8, 2026
@ryevdokimov ryevdokimov force-pushed the local-transform-gizmo-visible branch from 7945487 to 642cd2d Compare January 8, 2026 16:58
@ryevdokimov ryevdokimov requested a review from a team January 8, 2026 16:58
@ryevdokimov
Copy link
Contributor Author

I think this should be an option in EditorSettings

Done.

@ryevdokimov ryevdokimov force-pushed the local-transform-gizmo-visible branch from 642cd2d to 13943f7 Compare January 8, 2026 17:15
@ryevdokimov ryevdokimov requested a review from a team as a code owner January 8, 2026 17:15
@TokageItLab
Copy link
Member

TokageItLab commented Jan 8, 2026

Specifying “local mode” possibly cause scalability issues in the future. For example, considering the possibility that implementing ViewSpaceMode as mentioned in #114674 (comment). Could you implement checkboxes for global and local using a bitmask (int)?

like:

enum TransfromMode {
  TRANSFORM_MODE_GLOBAL = 1,
  TRANSFORM_MODE_LOCAL = 2,
  // TRANSFORM_MODE_VIEW = 4, <- Example, for extending bitmask flags, set `2^n` or `1 << n`.
};

EDITOR_SETTING(Variant::INT, PROPERTY_HINT_FLAGS, "editors/3d/show_gizmo_during_rotation", TRANSFORM_MODE_LOCAL, "Global,Local");

@ryevdokimov ryevdokimov force-pushed the local-transform-gizmo-visible branch 2 times, most recently from c1b036b to 4579ccb Compare January 9, 2026 00:12
@ryevdokimov
Copy link
Contributor Author

Sure:

image

@ryevdokimov ryevdokimov force-pushed the local-transform-gizmo-visible branch from 4579ccb to 3518b0d Compare January 9, 2026 12:26
Copy link
Member

@TokageItLab TokageItLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, LGTM

@akien-mga akien-mga merged commit 1085d9f into godotengine:master Jan 10, 2026
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@ryevdokimov ryevdokimov deleted the local-transform-gizmo-visible branch January 10, 2026 23:29
rivie13 pushed a commit to rivie13/Phoenix-Agentic-Engine that referenced this pull request Feb 16, 2026
…m-gizmo-visible

Keep other parts of transform gizmo visible when rotating in local mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New rotation gizmo doesn't show the axis in local space coordinates

4 participants

X Tutup