Fix DXIL view instancing workaround not getting applied correctly.#114645
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Jan 7, 2026
Merged
Conversation
clayjohn
approved these changes
Jan 6, 2026
Member
clayjohn
left a comment
clayjohn
left a comment
There was a problem hiding this comment.
Makes sense to me. Would be good to have @BastiaanOlij test it out and confirm that the fix works for him
BastiaanOlij
approved these changes
Jan 6, 2026
Contributor
BastiaanOlij
left a comment
BastiaanOlij
left a comment
There was a problem hiding this comment.
I can confirm this fixes the issue for stereo rendering:
Fix wise this goes over my head, I get why its broken but I defer to you and Clay on if this is the correct way to fix it.
It does seem to me that we should report this upstream and get it fixed, we can't be the only ones dealing with this..
Member
|
Thanks! |
rivie13
pushed a commit
to rivie13/Phoenix-Agentic-Engine
that referenced
this pull request
Feb 16, 2026
…xil-view-instancing-workaround Fix DXIL view instancing workaround not getting applied correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #114403.
Regression introduced by the Mesa version upgrade. It seems
dxil_spirv_nir_linknow removes dead variables, which breaks the view instancing workaround, since it deletes thegl_FragCoordvariable due to being unused in the shader code. We can instead add the variable after the optimization to ensure it stays.