Fix inconsistent MenuButton styles#114635
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Jan 6, 2026
Merged
Conversation
ad9bbd8 to
375a8f8
Compare
YeldhamDev
approved these changes
Jan 6, 2026
Member
|
Thanks! |
rivie13
pushed a commit
to rivie13/Phoenix-Agentic-Engine
that referenced
this pull request
Feb 16, 2026
Fix inconsistent MenuButton styles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes unnecessary
MenuButtonstyles and workarounds and fixes broken states of Animation button as a result.MenuButtondoesn't need any styles, it hasflat = trueby default (disables all styleboxes) and when it'sfalsegodot consistently usesFlatMenuButtontype variation everywhere to make them flat but with hover/pressed states. There are only 3 non-flat menu buttons in the entire editor with bothflat = falseand noFlatMenuButtonon them (Animation button, track Edit button and Actions in import dialog), all of which have overrides in_notificationto make them look like regularButton.This PR makes
MenuButtoninheritButtonstyles directly to remove those band-aids and match the expectation of it being a regularButtonas opposed toFlatMenuButton. I went through all of theMenuButtons in editor to make sure they consistently useFlatMenuButtontype variation where they should be flat, there are only a few such cases where it was missing.Classic theme, pressed state had wrong stylebox:
Modern theme, hovered state had wrong stylebox: