X Tutup
Skip to content

Fix inconsistent MenuButton styles#114635

Merged
akien-mga merged 1 commit intogodotengine:masterfrom
passivestar:flat-menu-button
Jan 6, 2026
Merged

Fix inconsistent MenuButton styles#114635
akien-mga merged 1 commit intogodotengine:masterfrom
passivestar:flat-menu-button

Conversation

@passivestar
Copy link
Contributor

@passivestar passivestar commented Jan 5, 2026

Removes unnecessary MenuButton styles and workarounds and fixes broken states of Animation button as a result.

MenuButton doesn't need any styles, it has flat = true by default (disables all styleboxes) and when it's false godot consistently uses FlatMenuButton type variation everywhere to make them flat but with hover/pressed states. There are only 3 non-flat menu buttons in the entire editor with both flat = false and no FlatMenuButton on them (Animation button, track Edit button and Actions in import dialog), all of which have overrides in _notification to make them look like regular Button.

This PR makes MenuButton inherit Button styles directly to remove those band-aids and match the expectation of it being a regular Button as opposed to FlatMenuButton. I went through all of the MenuButtons in editor to make sure they consistently use FlatMenuButton type variation where they should be flat, there are only a few such cases where it was missing.


Classic theme, pressed state had wrong stylebox:

Master PR
1 2

Modern theme, hovered state had wrong stylebox:

Master PR
3 4

@passivestar passivestar requested review from a team as code owners January 5, 2026 23:40
@passivestar passivestar requested a review from a team January 5, 2026 23:40
@akien-mga akien-mga merged commit c742d10 into godotengine:master Jan 6, 2026
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@passivestar passivestar deleted the flat-menu-button branch January 6, 2026 11:22
rivie13 pushed a commit to rivie13/Phoenix-Agentic-Engine that referenced this pull request Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup