GDExtension: Ensure LIBGODOT_API is always defined#114626
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Jan 6, 2026
Merged
GDExtension: Ensure LIBGODOT_API is always defined#114626akien-mga merged 1 commit intogodotengine:masterfrom
LIBGODOT_API is always defined#114626akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
dsnopek
approved these changes
Jan 5, 2026
Contributor
dsnopek
left a comment
dsnopek
left a comment
There was a problem hiding this comment.
Thanks! Looks good to me :-)
Member
|
Thanks! |
rivie13
pushed a commit
to rivie13/Phoenix-Agentic-Engine
that referenced
this pull request
Feb 16, 2026
GDExtension: Ensure `LIBGODOT_API` is always defined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a small oversight in
libgodot.h, where theLIBGODOT_APIlacked a fallback define for potentially unsupported compilers. Also adds#endifcomments to the__cpluspluswrappers, and removes the incorrect#endifcomment from theLIBGODOT_APIwrapper