GLTF: Fix getting animation track path#114581
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Jan 5, 2026
Merged
Conversation
aaronfranke
approved these changes
Jan 4, 2026
Member
aaronfranke
left a comment
aaronfranke
left a comment
There was a problem hiding this comment.
Makes sense to me. This defaults to ".." so it'll be the same in the common case and fix an issue in the uncommon case.
akien-mga
changed the title
Member
|
Thanks! |
rivie13
pushed a commit
to rivie13/Phoenix-Agentic-Engine
that referenced
this pull request
Feb 16, 2026
…ion-track-path GLTF: Fix getting animation track path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When attempting to get the animation node via the track path in
_convert_animation(), we previously assumed that the root node for the animation player was always the parent. Whileroot_nodefor the AnimationPlayer defaults to.., i.e. the parent, if theroot_nodeis set to something else, getting the animation node will fail.Changing getting the anim_player_parent according to the path set in
root_nodefixes the issue.