Fix SplitContainer set desired size infinite loop#114541
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Jan 3, 2026
Merged
Fix SplitContainer set desired size infinite loop#114541akien-mga merged 1 commit intogodotengine:masterfrom
akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
KoBeWi
approved these changes
Jan 3, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The checks in
SplitContainer::_set_desired_sizesfixes the infinite loop.The problem was the available space / shrink amount got to a small number like
1.2e-5whereis_zero_approxdidn't catch it but subtracting it resulted in no change. There is now a check to make sure that the available space changes. There is another check in the similar loop below it since it can have the same issue.Unrelated to the inf loop, the split offset was being changed when changing from a scene collection source to an atlas source.
This happened because the atlas was being shown before the scene collection was hidden, which made the SplitContainer try fit all 3 children, shrinking them, before it went down to 2 visible children. Since the order matters now I changed it to show only after hiding.