Merged
Conversation
Maran23
reviewed
Jan 2, 2026
Contributor
|
Tested it locally, it works - thanks for the fix! |
4 tasks
akien-mga
approved these changes
Jan 5, 2026
Maran23
approved these changes
Jan 5, 2026
Contributor
Maran23
left a comment
Maran23
left a comment
There was a problem hiding this comment.
Looks good to me, just one question.
| // Set the icon in the task manager (should we do this?). | ||
| SendMessage(windows[MAIN_WINDOW_ID].hWnd, WM_SETICON, ICON_BIG, (LPARAM)hicon); | ||
| for (const KeyValue<WindowID, WindowData> &E : windows) { | ||
| SendMessage(E.value.hWnd, WM_SETICON, ICON_SMALL, (LPARAM)icon_big); |
Contributor
There was a problem hiding this comment.
Question just to be sure: This should use icon_big and not icon_small, right?
Member
Author
There was a problem hiding this comment.
Yes, it is generated icon, so the same is used for both, icon_small is not set in this case.
Contributor
|
Thanks! |
rivie13
pushed a commit
to rivie13/Phoenix-Agentic-Engine
that referenced
this pull request
Feb 16, 2026
[Windows] Fix icon leak.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #114496
Supersede #113421
Bugsquad edit: Should also fix #113350