Fix discrete key is not processed by advance_on_start in AnimationNode#114487
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Jan 6, 2026
Merged
Fix discrete key is not processed by advance_on_start in AnimationNode#114487Repiteo merged 1 commit intogodotengine:masterfrom
advance_on_start in AnimationNode#114487Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
TokageItLab
force-pushed
the
fix-ad-start-animnode
branch
2 times, most recently
from
d08327c to
303ea06
Compare
TokageItLab
force-pushed
the
fix-ad-start-animnode
branch
from
303ea06 to
c8c0aa9
Compare
lyuma
approved these changes
Jan 6, 2026
Contributor
lyuma
left a comment
lyuma
left a comment
There was a problem hiding this comment.
I think it seems like a good change.
I feel a lot better knowing that the first keyframe (or last keyframe if PLAY_MODE_BACKWARD) is guaranteed to be processed in discrete animations rather than random behavior depending on the initial delta.
Contributor
|
Thanks! |
rivie13
pushed a commit
to rivie13/Phoenix-Agentic-Engine
that referenced
this pull request
Feb 16, 2026
…nimnode Fix discrete key is not processed by `advance_on_start` in AnimationNode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Force process the key immediately after start by similar way with
AnimationPlayer::_check_immediately_after_start().