Ensure clear_animation_instances() after blending frame result#114458
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Jan 6, 2026
Merged
Ensure clear_animation_instances() after blending frame result#114458akien-mga merged 1 commit intogodotengine:masterfrom
clear_animation_instances() after blending frame result#114458akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
lyuma
approved these changes
Jan 6, 2026
Contributor
lyuma
left a comment
lyuma
left a comment
There was a problem hiding this comment.
I see the animation_finished signal is emitted from AnimationPlayer::_blend_post_process(), so this fixes cases where the AnimationPlayer is affected by signal callbacks from animations. I think this fix looks good for the animation_finished signal -> advance() case.
Note: TYPE_METHOD tracks are called in AnimationMixer::_blend_process (unless deferred mode is being used), and _blend_process happens before the moved line, so this PR will not solve cases where the user advances the animation player from inside a call method track (unless they enable deferred mode)
lyuma
moved this from Ready for review
to Approved, Waiting for Production
in Animation Team Issue Triage
github-project-automation
bot
moved this from Approved, Waiting for Production
to Done
in Animation Team Issue Triage
Member
|
Thanks! |
rivie13
pushed a commit
to rivie13/Phoenix-Agentic-Engine
that referenced
this pull request
Feb 16, 2026
…me-after-apply Ensure `clear_animation_instances()` after blending frame result
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discard animation instances at an earlier stage than currently. They become removable after blending.