Fix crash after calling EditorUndoRedoManager.clear_history() and then interacting with history dock entries#114439
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Jan 1, 2026
Conversation
Member
That's a mistake. It's supposed to clear every history (including global). You may leave out remote though. |
…hen interacting with history dock entries
ryevdokimov
force-pushed
the
fix-undo-redo-crash
branch
from
001e4a5 to
dc08fd4
Compare
KoBeWi
approved these changes
Dec 30, 2025
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #114429
This makes the
clear_history()method actually perform the function per the documentation, although it originally tries to clear all history. I think the documented approach makes more sense though.Either way the undo/redo stack needs to be cleared to prevent the crash.