X Tutup
Skip to content

Fix setting mesh blend shape properties in dummy mesh storage#114356

Merged
akien-mga merged 1 commit intogodotengine:masterfrom
nikitalita:fix-dummy-mesh-blend-shape
Jan 6, 2026
Merged

Fix setting mesh blend shape properties in dummy mesh storage#114356
akien-mga merged 1 commit intogodotengine:masterfrom
nikitalita:fix-dummy-mesh-blend-shape

Conversation

@nikitalita
Copy link
Contributor

@nikitalita nikitalita commented Dec 26, 2025 •
edited
Loading

When using the dummy rendering server, ImporterMesh::add_surface() fails if the mesh has blend shapes:

ERROR: Condition "blend_shape_count != (uint32_t)mesh_get_blend_shape_count(p_mesh)" is true. Returning: Array()
	at: mesh_surface_get_blend_shape_arrays (servers/rendering_server.cpp:1774)
ERROR: Condition "p_blend_shapes.size() != blend_shapes.size()" is true.
	at: add_surface (scene/resources/3d/importer_mesh.cpp:68)

This causes various things, like the scene importers, to produce inaccurate scenes when running headless.

This is caused by the dummy mesh storage not actually setting and getting the blend_shape_count/blend_shape_mode. Implementing those fixes the issue.

@nikitalita nikitalita requested a review from a team as a code owner December 26, 2025 21:02
@fire fire requested a review from a team December 27, 2025 18:39
@fire
Copy link
Member

fire commented Dec 27, 2025

Probably want rendering to take a look too.

@Chaosus Chaosus added this to the 4.6 milestone Dec 28, 2025
@akien-mga akien-mga added the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Jan 1, 2026
clayjohn
clayjohn approved these changes Jan 6, 2026
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@akien-mga akien-mga merged commit 23b7415 into godotengine:master Jan 6, 2026
20 checks passed
@akien-mga
Copy link
Member

akien-mga commented Jan 6, 2026

Thanks!

@akien-mga
Copy link
Member

akien-mga commented Jan 8, 2026

Cherry-picked for 4.5.2.

@akien-mga akien-mga removed the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Jan 8, 2026
rivie13 pushed a commit to rivie13/Phoenix-Agentic-Engine that referenced this pull request Feb 16, 2026
@akien-mga
Merge pull request godotengine#114356 from nikitalita/fix-dummy-mesh-…
6408924 
…blend-shape

Fix setting mesh blend shape properties in dummy mesh storage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fire fire fire approved these changes

@clayjohn clayjohn clayjohn approved these changes

Assignees

No one assigned

Labels

bug topic:import topic:rendering

Projects

None yet

Milestone

4.6

Development

Successfully merging this pull request may close these issues.

5 participants

@nikitalita @fire @akien-mga @clayjohn @Chaosus
X Tutup