Create new pools when they become fragmented on Vulkan.#114313
Conversation
There was a problem hiding this comment.
Confirmed this to fix the issue in Rift Riff on Android, thus hopefully reducing crash rate on android by at least 60-80%! Before this change, on one of my shitty android devices, the game would crash after 1–5 minutes. After this change, I can no longer reproduce the bug at all on that same device – no crash during a full hour of automated play through.
i already pushed a new version of rift riff to google play and will know in two weeks from now whether this fix has fully eliminated the crash.
massive thanks to @clayjohn, @akien-mga, @Alex2782, and @blueskythlikesclouds for all their help debugging and fixing this issue!
(here is the 525-replies megathread where we debugged and discussed this issue.)
There was a problem hiding this comment.
Looks great to me!
We are still trying to understand why we are getting fragmented pools with this strategy, but this code should work in the meantime. edit (Dario found out why lol #114657)
In the long term, we may want to overhaul our descriptor set management code altogether since it can likely be made to be more efficient on all platforms, both in terms of per-frame CPU cost and memory usage
|
Thanks! |
|
Cherry-picked for 4.5.2. |
Confirmed to fix #112157.
Should be cherry-picked to 4.5.2 as well.