Fix setter for readonly bone name in the joint array and add null check in IKModifier3D#114240
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Jan 1, 2026
Merged
Conversation
Member
|
You can also keep the setter but set no storage flag |
Member
Author
|
But those members are read-only so no point to keep them, although I'm keeping the getter because it helps scripts find the currently processed joints. |
Member
|
I think we should approve this, but I'm not sure about read only properties. Anyone else have an alternative. |
github-project-automation
bot
moved this to Unassessed
in 4.x Release Priorities & Blockers
TokageItLab
moved this from Unassessed
to Very Bad
in 4.x Release Priorities & Blockers
akien-mga
approved these changes
Jan 1, 2026
github-project-automation
bot
moved this from Ready for review
to Done
in Animation Team Issue Triage
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not a fundamental fix, but I am committing it because I determined there are no side effects.
These properties should not be serialized in the first place. Although I haven't marked them as STORAGE in Usage, they are somehow being serialized to tscn. Therefore, I believe this is fundamentally a serialization bug.
However, these properties are already read-only and only allow access from within the C++ core. So, removing the function calls from the setters resolves the issue.
Additionally, make the joint array API for LimitAngularModifier consistent with other SkeletonModifiers. The indexing was broken, but this fixes it.
Before:
After fix:
FYI, since joint array elements are dynamically generated, changing their paths will not cause compatibility breaks.