Fix OpenGL motion vector regression#114227
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Dec 21, 2025
Merged
Conversation
github-project-automation
bot
moved this to Unassessed
in 4.x Release Priorities & Blockers
BastiaanOlij
moved this from Unassessed
to Release Blocker
in 4.x Release Priorities & Blockers
BastiaanOlij
force-pushed
the
fix_asp_regression
branch
from
52db760 to
2fb955a
Compare
devloglogan
approved these changes
Dec 20, 2025
Contributor
devloglogan
left a comment
devloglogan
left a comment
There was a problem hiding this comment.
This fixes the regression from my quick test! 😄 Thanks!
Side note, you might also want to add a typo fix for this variable from your previous PR.
BastiaanOlij
force-pushed
the
fix_asp_regression
branch
from
2fb955a to
3a486ef
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out the
layout(std140) uniform SceneData prev_scene_data; // ubo:12notation doesn't actually work, so splitting the UBO into two to work around the memory alignment issue only partially worked.We'll need to investigate at some point in time whether this notation can be made to work, but for now I fixed the regression by going to the older notation that we seem to be using throughout the compatibility renderer.
Fixes #114203