OpenXR: Don't create a visibility mask mesh without data#114181
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Dec 21, 2025
Merged
OpenXR: Don't create a visibility mask mesh without data#114181akien-mga merged 1 commit intogodotengine:masterfrom
akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
BastiaanOlij
added
the
cherrypick:4.5
dsnopek
approved these changes
Dec 19, 2025
Contributor
dsnopek
left a comment
dsnopek
left a comment
There was a problem hiding this comment.
Thanks! I haven't tested, but the code looks good to me :-)
m4gr3d
approved these changes
Dec 19, 2025
Member
|
Thanks! |
Member
|
Cherry-picked for 4.5.2. |
akien-mga
removed
the
cherrypick:4.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenXR visibility mask extension will attempt to retrieve a visibility mask from the runtime if this extension is supported.
It is however possible that no such mask is available in which case no data will be returned. We still attempted to create a mesh which lead to console errors.
This can be reproduced with SteamVR using a headset like the Quest 3 using SteamLink.
This PR changes the logic so a mesh is only created once data is received.
Fixes #111376