Fix changing directory in FileDialog#114177
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Dec 19, 2025
Merged
Conversation
BastiaanOlij
approved these changes
Dec 19, 2025
Contributor
BastiaanOlij
left a comment
BastiaanOlij
left a comment
There was a problem hiding this comment.
Can confirm, fixes my issue! thanks!
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Who would've though that navigating to root directory on every directory traverse would cause problems 🙃
It worked in EditorFileDialog, because it was using
DirAccess->change_dir()directly everywhere, instead of always going through the helper method.Fixes #114174