Finalize colors of modern theme#114162
Conversation
|
Shouldn't popup menus have rounded corners? |
yes but you can't do it through theming alone because they are currently drawn in separate non-transparent windows and that will need to be changed first |
|
The new colours seem good and well balanced, though the "active tab" text (3D) highlight seems less noticeable.
Text contrast in the file system and scene tree also seems lower due to the brighter background, particularly for currently selected items ("Player" node and "cloud.glb"). May be good to record some contrast ratios to compare with standards. |
passivestar
force-pushed
the
modern-theme-colors
branch
from
afa8880 to
c054cca
Compare
Fixed. Also fixed overbrightened project tags, overly contrasty backgrounds of editor shortcuts, code blocks blending with help background, and added hover-pressed highlights to the project list |
passivestar
force-pushed
the
modern-theme-colors
branch
from
c054cca to
d0dd18b
Compare
passivestar
force-pushed
the
modern-theme-colors
branch
from
d0dd18b to
8e20f4c
Compare
|
Thanks! |
The contrast of this panel still seems insufficient. |
6 participants
Addresses most of remaining contrast-related feedback and simplifies logic of
_get_base_color(). Doing it all in one PR because a lot of these changes are interdependentCloses #112230
Closes #112385
Closes #114031
Supersedes #112558
Full list of changes:
Moves the contrast multiplier from the editor setting to the theme, restoring
0.3as the default value.Simplifies the logic of
_get_base_color()and adds support for negative contrast. Since we're now lerping the same amount regardless of whether the dimness offset is positive or negative we have simpler calls to_get_base_color()and more predictable values in light themes. It now works similar to how it did in classic theme. Because of that the light theme now also uses the same contrast of-0.06for the light theme as the classic theme.Changes base color from
#272727to#292929to make panels and tabs easier to distinguish.Slightly increases the default font and icon brightness (0.7 -> 0.75, 0.7 -> 0.8) to improve readability.
Increases brightness of inactive tab font and icon (they became too dim when support for themable tab icon colors was introduced, which is especially noticeable in scene tabs).
Makes popup menus darker to make them blend less with inspector properties. This isn't perfect and is more of a mitigation than a fix for now because there's not a lot of range to work with there. When popup menus are reworked to support shadows (Make
per_pixel_transparencyalways enabled in the editor #106324) it will be more feasible to make them elevated (i.e see MakePopupMenu/Panelshadows properly visible again #91333 (comment))More subtle hover indication in popup menus.
Reduces brightness of backgrounds of pressed flat buttons (i.e in toolbars) to make their icons more readable.
Makes the selected editor property brighter to make it easier to see it.
Progressbars in dark popups have different colors now to account for new dark popup background.
Project list items now use their own colors instead of Tree colors to make the hover indication more fitting for their background
Audio bus effect list has a more fitting background color now, the secondary tree one was too contrasty for the audio bus background.
Fixes overbrightened font color on checkboxes.
Headers of sidebar trees now have their own colors that look better on sidebar backgrounds, while regular tree headers are less contrasty and more fitting for regular backgrounds.
Fixes overbrightened project tags.
Adds missing hover-pressed state to project list.
Fixes code blocks blending with help background.