X Tutup
Skip to content

Fix TabContainer's minimum size ignoring the popup button#114115

Merged
akien-mga merged 1 commit intogodotengine:masterfrom
YeldhamDev:dont_clip_that_please
Dec 18, 2025
Merged

Fix TabContainer's minimum size ignoring the popup button#114115
akien-mga merged 1 commit intogodotengine:masterfrom
YeldhamDev:dont_clip_that_please

Conversation

@YeldhamDev
Copy link
Member

Fixes #114111.
Reverts #113938.

@KoBeWi
Copy link
Member

KoBeWi commented Dec 17, 2025

Issue aside, this doesn't completely fix the titular problem in TabContainer:

image

The button may still end up outside bounds.

It's better than before though (beta1):

image

EDIT:

It works correctly when clip_tabs is disabled.

@AThousandShips
Copy link
Member

Can confirm this solves #114111

@YeldhamDev
Copy link
Member Author

YeldhamDev commented Dec 17, 2025

@KoBeWi Huh? It works correctly on my end, even with clip_tabs enabled:

Screencast_20251217_175303.webm

Did you do something specific?

@KoBeWi
Copy link
Member

KoBeWi commented Dec 17, 2025

Nevermind, this is unrelated bug.
When you call set_popup() or change clip_tabs the TabContainer won't update minimum size.

@KoBeWi

This comment was marked as resolved.

@YeldhamDev YeldhamDev force-pushed the dont_clip_that_please branch from f70e4b3 to 4383cd0 Compare December 17, 2025 21:27
@akien-mga akien-mga merged commit 42f49e4 into godotengine:master Dec 18, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@YeldhamDev YeldhamDev deleted the dont_clip_that_please branch December 18, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GridMap editor unusably wide and wastes space

4 participants

X Tutup