CI: Fix executable perms for various files#114047
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Dec 15, 2025
Merged
Conversation
akien-mga
approved these changes
Dec 15, 2025
Calinou
approved these changes
Dec 15, 2025
Member
Calinou
left a comment
Calinou
left a comment
There was a problem hiding this comment.
Looks good to me.
I agree we can safely remove # -*- coding: utf-8 -*- from files (it's a Python 2 holdover).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements two new pre-commit hooks to ensure executable perms are enforced when a shebang is present. This also caught a few files erroneously labeled as executable, and removed/added shebangs where relevant
NOTE: SCons files are a special case, as their shebangs were to support syntax highlighting. This was integrated in #6850, which was nearly a decade ago, so it might not be relevant anymore. However, I consider that decision outside the scope of this PR, so they're excluded from the new hooks for the time being