X Tutup
Skip to content

Fix ScrollContainer's bottom scroll hint ignoring margins#114037

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
YeldhamDev:scrollcon_hint_fix
Dec 17, 2025
Merged

Fix ScrollContainer's bottom scroll hint ignoring margins#114037
Repiteo merged 1 commit intogodotengine:masterfrom
YeldhamDev:scrollcon_hint_fix

Conversation

@YeldhamDev
Copy link
Member

@YeldhamDev YeldhamDev commented Dec 15, 2025

You can see the issue in action on the bus editor.

Before After
Screenshot_20251216_110037 image

@YeldhamDev YeldhamDev added this to the 4.6 milestone Dec 15, 2025
@YeldhamDev YeldhamDev added the bug label Dec 15, 2025
@YeldhamDev YeldhamDev requested a review from a team as a code owner December 15, 2025 14:54
@KoBeWi
Copy link
Member

KoBeWi commented Dec 16, 2025

I don't see any difference.

@YeldhamDev
Copy link
Member Author

@KoBeWi I've updated the OP with images.

@KoBeWi
Copy link
Member

KoBeWi commented Dec 16, 2025

It's still ~one pixel off

godot.windows.editor.dev.x86_64_HSHH2lpHY3.mp4

@YeldhamDev
Copy link
Member Author

If it's truly one pixel then it's by design, so the scroll doesn't need to be precisely at 0/max value in order for them to hide.

@Repiteo Repiteo merged commit 590c310 into godotengine:master Dec 17, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 17, 2025

Thanks!

@YeldhamDev YeldhamDev deleted the scrollcon_hint_fix branch December 17, 2025 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup