X Tutup
Skip to content

Write to animation import settings only when needed to prevent bloating the .import file#114015

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
Jordyfel:import-file-bloat
Dec 15, 2025
Merged

Write to animation import settings only when needed to prevent bloating the .import file#114015
Repiteo merged 1 commit intogodotengine:masterfrom
Jordyfel:import-file-bloat

Conversation

@Jordyfel
Copy link
Contributor

Fix #114008

This preserves the logic of the previous PR that writes to import settings to preserve changes by import hints, but does it only if such a change exists to prevent file size bloat if both import settings and hints are not used.

@Jordyfel Jordyfel requested a review from a team as a code owner December 14, 2025 14:43
@Jordyfel Jordyfel changed the title Write to animation import settings only when needed to prevent to Write to animation import settings only when needed to prevent to prevent bloating the .import file Dec 14, 2025
@Jordyfel Jordyfel changed the title Write to animation import settings only when needed to prevent to prevent bloating the .import file Write to animation import settings only when needed to prevent bloating the .import file Dec 14, 2025
Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@AThousandShips AThousandShips added this to the 4.6 milestone Dec 15, 2025
@Repiteo Repiteo merged commit 53fb0f0 into godotengine:master Dec 15, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 15, 2025

Thanks!

@Jordyfel Jordyfel deleted the import-file-bloat branch December 16, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Importing a glb file with animations creates a huge .import file

4 participants

X Tutup