Update access-kit to 0.18.0#113990
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Dec 15, 2025
Merged
Conversation
Repiteo
approved these changes
Dec 13, 2025
Member
Author
|
Note: last push added update to dynamic lib wrapper, which I forgot to update. |
Contributor
|
Thanks! |
akien-mga
reviewed
Dec 15, 2025
Comment on lines
162
to
+170
| uses: dsaltares/fetch-gh-release-asset@1.1.2 | ||
| with: | ||
| repo: AccessKit/accesskit-c | ||
| version: tags/0.17.0 | ||
| file: accesskit-c-0.17.0.zip | ||
| target: accesskit-c-0.17.0/accesskit_c.zip | ||
| version: tags/0.18.0 | ||
| file: accesskit-c-0.18.0.zip | ||
| target: accesskit-c-0.18.0/accesskit_c.zip | ||
|
|
||
| - name: Extract pre-built AccessKit | ||
| run: unzip -o accesskit-c-0.17.0/accesskit_c.zip | ||
| run: unzip -o accesskit-c-0.18.0/accesskit_c.zip |
Member
There was a problem hiding this comment.
Not urgent, but I think we could move the accesskit part to .github/actions/ instead of being in the workflow, and then just have the workflows enable it conditionally with accesskit: true.
That would reduce duplication both for the version number and for the 3 platforms that include it.
CC @Repiteo
Member
Author
There was a problem hiding this comment.
It might be worth integrating it directly to the build system and auto download all dependencies, especially with D3D12 is enabled by default, which is already causing issues with MESA libs for custom builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.