Wayland: Fix accidental copy during global remove#113946
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Dec 16, 2025
Merged
Wayland: Fix accidental copy during global remove#113946akien-mga merged 1 commit intogodotengine:masterfrom
akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
We were accidentally mutating a copy during cleanup of the viewporter and fractional scale manager. Thank you Aaron Franke for finding this out :D
bruvzg
approved these changes
Dec 16, 2025
bruvzg
added
the
cherrypick:4.5
Member
|
Thanks! |
Member
|
Cherry-picked for 4.5.2. |
akien-mga
removed
the
cherrypick:4.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were accidentally mutating a copy during cleanup of the viewporter and fractional scale manager.
Thank you Aaron Franke for finding this out :D
FTR, this hasn't been a problem for now as no major compositor removes these globals in realtime, but nothing stops a compositor from doing that. In general I plan to test and improve the global handling logic much more, but that will require quite a bit of work. My experience with the embedder might come in handy for this.
Cherry-pickable to 4.5.