[Vector4] Fix loss of precision with division#113848
[Vector4] Fix loss of precision with division#113848Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
|
Note for the future, please don't link or reference issues or PRs in the commit message, it creates a lot of unnecessary noise in the issue (it'll add a note in the issue every time this commit is pushed) |
|
Sorry about that. |
AThousandShips
left a comment
AThousandShips
left a comment
There was a problem hiding this comment.
LGTM, I don't expect the change from pre-division to pure division to create any real performance issues, but it does solve the precision issue which I think is more critical (this code was added when Vector4 was first added, so was not an intentional change for performance at a later time)
Just to clarify so that I don't get it wrong in the future, is it fine to put it in the PR's actual body/message (not the commit message), or should I avoid it there as well? |
|
Note for release management: Because it changes the exact values of the result this could technically be considered a compatibility breakage, but I'm leaving the label off for now, feel free to add it if it is considered significant, also holding off adding cherry-picking to this for the same reason Code using |
|
Please do put it in the PR description, see here |
Ivorforce
left a comment
Ivorforce
left a comment
There was a problem hiding this comment.
Makes sense, I'm guessing the previous author just thought to be clever and save lines edited. If we need divisions, we should do divisions.
|
Thanks! |
5 participants
Resolves #113847